Update bootstrap-checks.asciidoc#48975
Merged
jrodewig merged 2 commits intoelastic:masterfrom Nov 27, 2019
daixiang0:patch-1
Merged
Update bootstrap-checks.asciidoc#48975jrodewig merged 2 commits intoelastic:masterfrom daixiang0:patch-1
jrodewig merged 2 commits intoelastic:masterfrom
daixiang0:patch-1
Conversation
Comment how to update max size if virtual memory more clearly. Signed-off-by: Xiang Dai <764524258@qq.com>
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
Contributor
Author
|
any update? @elastic/es-core-infra |
Contributor
|
@elasticmachine test this please. |
jrodewig
reviewed
Nov 26, 2019
jrodewig
reviewed
Nov 26, 2019
jrodewig
reviewed
Nov 26, 2019
Contributor
|
Thanks for your contribution @daixiang0. I left some suggestions for your consideration. After you address them, we can work on merging these changes in. |
Contributor
Author
|
@jrodewig done. |
Contributor
|
@elasticmachine test this please |
jrodewig
approved these changes
Nov 27, 2019
Contributor
jrodewig
left a comment
There was a problem hiding this comment.
LGTM. Thanks @daixiang0. I'll get this merged and backported.
jrodewig
pushed a commit
that referenced
this pull request
Nov 27, 2019
jrodewig
pushed a commit
that referenced
this pull request
Nov 27, 2019
jrodewig
pushed a commit
that referenced
this pull request
Nov 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment how to update max size of virtual memory more clearly.
Signed-off-by: Xiang Dai 764524258@qq.com