Fix ignoring missing values in min/max aggregations#48970
Merged
imotov merged 1 commit intoelastic:masterfrom Nov 12, 2019
Merged
Conversation
Fixes the issue when the missing values can be ignored in min/max due to BKD optimization. Fixes elastic#48905
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
polyfractal
approved these changes
Nov 12, 2019
Contributor
polyfractal
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
Contributor
|
@imotov any chance of getting this into |
imotov
added a commit
that referenced
this pull request
Nov 13, 2019
Fixes the issue when the missing values can be ignored in min/max due to BKD optimization. Fixes #48905
Contributor
Author
|
I merged it to master (8.0.0) and 7.x (7.6.0) at the moment. I think we are too late for 7.5.0, but I might be able to backport it to 7.5.1. Not sure if 7.4.3 is going to happen. @jimczi what do you think? |
imotov
added a commit
that referenced
this pull request
Nov 15, 2019
Fixes the issue when the missing values can be ignored in min/max due to BKD optimization. Fixes #48905
Contributor
|
Thanks for the |
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue when the missing values can be ignored in min/max
due to BKD optimization.
Fixes #48905