Ignore dangling indices created in newer versions#48652
Merged
DaveCTurner merged 2 commits intoelastic:masterfrom Oct 31, 2019
Merged
Ignore dangling indices created in newer versions#48652DaveCTurner merged 2 commits intoelastic:masterfrom
DaveCTurner merged 2 commits intoelastic:masterfrom
Conversation
DaveCTurner
reviewed
Oct 29, 2019
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Thanks @rvl101, this looks like a reasonable approach. I left a couple of small suggestions.
server/src/main/java/org/elasticsearch/gateway/LocalAllocateDangledIndices.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/indices/IndicesServiceTests.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
Contributor
Author
|
Thanks for the feedback, @DaveCTurner. I've made the changes. |
Member
|
@elasticmachine test this please |
Member
|
Failure looks unrelated, tracked in #42577 @elasticmachine please run elasticsearch-ci/1 |
DaveCTurner
pushed a commit
that referenced
this pull request
Oct 31, 2019
Today it is possible that we import a dangling index that was created in a newer version than one or more of the nodes in the cluster. Such an index would prevent the older node(s) from rejoining the cluster if they were to briefly leave it for some reason. This commit prevents the import of such dangling indices. Fixes #34264
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today it is possible that we import a dangling index that was created in a
newer version than one or more of the nodes in the cluster. Such an index would
prevent the older node(s) from rejoining the cluster if they were to briefly
leave it for some reason. This commit prevents the import of such dangling
indices.
Fixes #34264