SQL: binary communication implementation for drivers and the CLI#48261
Merged
astefan merged 12 commits intoelastic:masterfrom Oct 31, 2019
Merged
SQL: binary communication implementation for drivers and the CLI#48261astefan merged 12 commits intoelastic:masterfrom
astefan merged 12 commits intoelastic:masterfrom
Conversation
Add request parameter to disable binary response and fallback to json for drivers only, for debugging purposes.
Collaborator
|
Pinging @elastic/es-search (:Search/SQL) |
matriv
reviewed
Oct 21, 2019
Contributor
matriv
left a comment
There was a problem hiding this comment.
Nice work! Left some comments though, but for some maybe I'm just confused.
x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/rest/RestSqlTestCase.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/rest/RestSqlTestCase.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/rest/BaseRestSqlTestCase.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/rest/BaseRestSqlTestCase.java
Outdated
Show resolved
Hide resolved
...sql/qa/security/src/test/java/org/elasticsearch/xpack/sql/qa/security/RestSqlSecurityIT.java
Show resolved
Hide resolved
x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/SqlProtocolTestCase.java
Show resolved
Hide resolved
Contributor
|
Shouldn't the 7.x label be |
Contributor
I think so, 7.5.0 has already a build candidate: |
configuration for CLI.
matriv
reviewed
Oct 24, 2019
Contributor
matriv
left a comment
There was a problem hiding this comment.
Great work @astefan! And really nice testing!
I left some comments, most very minor. I'm a bit concerned about this though: https://github.com/elastic/elasticsearch/pull/48261/files#diff-fceb0a242e81eb82e7a233209889929fR65 if you could take another look.
x-pack/plugin/sql/sql-client/src/main/java/org/elasticsearch/xpack/sql/client/HttpClient.java
Show resolved
Hide resolved
...plugin/sql/sql-cli/src/test/java/org/elasticsearch/xpack/sql/cli/ConnectionBuilderTests.java
Outdated
Show resolved
Hide resolved
...ck/plugin/sql/sql-proto/src/main/java/org/elasticsearch/xpack/sql/proto/SqlQueryRequest.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/sql/sql-cli/src/main/java/org/elasticsearch/xpack/sql/cli/ConnectionBuilder.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/sql/sql-cli/src/main/java/org/elasticsearch/xpack/sql/cli/Cli.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/rest/RestSqlTestCase.java
Show resolved
Hide resolved
x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/rest/RestSqlTestCase.java
Show resolved
Hide resolved
.../sql/sql-client/src/test/java/org/elasticsearch/xpack/sql/client/HttpClientRequestTests.java
Outdated
Show resolved
Hide resolved
.../sql/sql-client/src/test/java/org/elasticsearch/xpack/sql/client/HttpClientRequestTests.java
Outdated
Show resolved
Hide resolved
.../sql/sql-client/src/test/java/org/elasticsearch/xpack/sql/client/HttpClientRequestTests.java
Outdated
Show resolved
Hide resolved
bpintea
reviewed
Oct 24, 2019
x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/SqlProtocolTestCase.java
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
costin
approved these changes
Oct 27, 2019
Member
costin
left a comment
There was a problem hiding this comment.
LGTM. The only concern I have is around the parameter name - binary is fairly vague and I would give it some more context (binary protocol, binary encoding,etc...).
| static final ParseField FIELD_MULTI_VALUE_LENIENCY = new ParseField("field_multi_value_leniency"); | ||
| static final ParseField INDEX_INCLUDE_FROZEN = new ParseField("index_include_frozen"); | ||
|
|
||
| static final ParseField BINARY_COMMUNICATION = new ParseField("binary"); |
Member
There was a problem hiding this comment.
I find "binary" confusing - how about binary_format or binary_protocol?
Contributor
Author
There was a problem hiding this comment.
binary_format it is, I'll change it.
| * See {@code SqlTranslateRequest.toXContent} | ||
| */ | ||
| private Boolean columnar = Boolean.FALSE; | ||
| private Boolean binaryCommunication = null; |
Member
There was a problem hiding this comment.
Move the defaults in the Protocol class as the other classes (same for columnar).
binary.format for jdbc.
astefan
added a commit
that referenced
this pull request
Nov 1, 2019
) * Introduce binary_format request parameter (binary.format for JDBC) to disable binary communication between clients (jdbc/odbc) and server. * for CLI - "binary" command line parameter (or -b) is introduced. Default value is "true". * binary communication (cbor) is enabled by default * disabling request parameter introduced for debugging purposes only (cherry picked from commit f96a5ca)
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds binary (CBOR) communication between server and drivers (JDBC/ODBC) and, also, the CLI. It, also, introduces a request parameter -
binary- with debugging purposes to disable the binary response and get back to JSON text format when needed. But, by default, when the parameter is not specifically set, the behavior is to encode the response in CBOR format.Implementation for #47785.