Fix link to GCP upload in build scans#48248
Merged
alpar-t merged 3 commits intoelastic:masterfrom Oct 21, 2019
Merged
Conversation
Also changed the name of the link to make it less confusing
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
approved these changes
Oct 18, 2019
Contributor
mark-vieira
left a comment
There was a problem hiding this comment.
One comment regarding naming, otherwise LGTM.
gradle/build-scan.gradle
Outdated
| link 'Jenkins Build', System.getenv('BUILD_URL') | ||
| link 'GCP Upload', | ||
| "https://console.cloud.google.com/storage/elasticsearch-ci-artifacts/jobs/${jobName}/${buildNumber}.tar.bz2" | ||
| link 'GCP Logs', |
Contributor
There was a problem hiding this comment.
I'm inclined to call this something more like "Build Logs" or "Additional build logs". The "GCP" bit here is irrelevant. If these were stored in S3 it would make no functional difference.
Contributor
Author
|
@elasticmachine update branch |
1 similar comment
Contributor
Author
|
@elasticmachine update branch |
alpar-t
added a commit
that referenced
this pull request
Oct 21, 2019
* Fix link to GCP upload in build scans Also changed the name of the link to make it less confusing * Change the name
alpar-t
added a commit
that referenced
this pull request
Oct 21, 2019
* Fix link to GCP upload in build scans Also changed the name of the link to make it less confusing * Change the name
alpar-t
added a commit
that referenced
this pull request
Oct 21, 2019
* Fix link to GCP upload in build scans Also changed the name of the link to make it less confusing * Change the name
alpar-t
added a commit
that referenced
this pull request
Oct 22, 2019
* Fix link to GCP upload in build scans Also changed the name of the link to make it less confusing * Change the name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changed the name of the link to make it less confusing