Skip to content

Remove Redundant Version Param from Repository APIs#48231

Merged
original-brownbear merged 3 commits intoelastic:masterfrom
original-brownbear:drop-redundant-version
Oct 21, 2019
Merged

Remove Redundant Version Param from Repository APIs#48231
original-brownbear merged 3 commits intoelastic:masterfrom
original-brownbear:drop-redundant-version

Conversation

@original-brownbear
Copy link
Copy Markdown
Contributor

This parameter isn't used by any implementation

This parameter isn't used by any implementation
@original-brownbear original-brownbear added >non-issue :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.6.0 labels Oct 18, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@original-brownbear original-brownbear changed the title Remove Version from Repository#IndexShardSnapshotStatus Remove Redundant Version Param from Repository APIs Oct 18, 2019
@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins test this

2 similar comments
@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins test this

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins test this

@original-brownbear
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

Copy link
Copy Markdown
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Armin

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Thanks Tanguy!

@original-brownbear original-brownbear merged commit 6563c0f into elastic:master Oct 21, 2019
@original-brownbear original-brownbear deleted the drop-redundant-version branch October 21, 2019 13:05
original-brownbear added a commit that referenced this pull request Oct 21, 2019
This parameter isn't used by any implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue v7.6.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants