Quieter logging from the DiskThresholdMonitor#48115
Merged
DaveCTurner merged 6 commits intoelastic:masterfrom Oct 18, 2019
Merged
Quieter logging from the DiskThresholdMonitor#48115DaveCTurner merged 6 commits intoelastic:masterfrom
DaveCTurner merged 6 commits intoelastic:masterfrom
Conversation
Today if an Elasticsearch node reaches a disk watermark then it will repeatedly emit logging about it, which implies that some action needs to be taken by the administrator. This is misleading. Elasticsearch strives to keep nodes under the high watermark, but it is normal to have a few nodes occasionally exceed this level. Nodes may be over the low watermark for an extended period without any ill effects. This commit enhances the logging emitted by the `DiskThresholdMonitor` to be less misleading. The expected case of hitting the high watermark and immediately relocating one or more shards that to bring the node back under the watermark again is reduced in severity to `INFO`. Additionally, `INFO` messages are not emitted repeatedly. Fixes elastic#48038
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
henningandersen
approved these changes
Oct 16, 2019
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
I left a couple of minor comments to consider.
server/src/main/java/org/elasticsearch/cluster/routing/allocation/DiskThresholdMonitor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/routing/allocation/DiskThresholdMonitor.java
Show resolved
Hide resolved
...er/src/test/java/org/elasticsearch/cluster/routing/allocation/DiskThresholdMonitorTests.java
Show resolved
Hide resolved
...java/org/elasticsearch/cluster/routing/allocation/decider/DiskThresholdDeciderUnitTests.java
Show resolved
Hide resolved
DaveCTurner
added a commit
that referenced
this pull request
Oct 18, 2019
Today if an Elasticsearch node reaches a disk watermark then it will repeatedly emit logging about it, which implies that some action needs to be taken by the administrator. This is misleading. Elasticsearch strives to keep nodes under the high watermark, but it is normal to have a few nodes occasionally exceed this level. Nodes may be over the low watermark for an extended period without any ill effects. This commit enhances the logging emitted by the `DiskThresholdMonitor` to be less misleading. The expected case of hitting the high watermark and immediately relocating one or more shards that to bring the node back under the watermark again is reduced in severity to `INFO`. Additionally, `INFO` messages are not emitted repeatedly. Fixes #48038
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today if an Elasticsearch node reaches a disk watermark then it will repeatedly
emit logging about it, which implies that some action needs to be taken by the
administrator. This is misleading. Elasticsearch strives to keep nodes under
the high watermark, but it is normal to have a few nodes occasionally exceed
this level. Nodes may be over the low watermark for an extended period without
any ill effects.
This commit enhances the logging emitted by the
DiskThresholdMonitorto beless misleading. The expected case of hitting the high watermark and
immediately relocating one or more shards that to bring the node back under the
watermark again is reduced in severity to
INFO. Additionally,INFOmessagesare not emitted repeatedly.
Fixes #48038