Scripting: get context names REST API#48026
Merged
stu-elastic merged 11 commits intoelastic:masterfrom Oct 16, 2019
Merged
Conversation
Adds `GET /_script_context`, returning a `contexts` object with each
available context as a key whose value is an empty object. eg.
```
{
"contexts": {
"aggregation_selector": {},
"aggs": {},
"aggs_combine": {},
...
}
}
```
refs: elastic#47411
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
rjernst
reviewed
Oct 15, 2019
Member
rjernst
left a comment
There was a problem hiding this comment.
Looking good! I have a few comments.
...main/java/org/elasticsearch/action/admin/cluster/storedscripts/GetScriptContextResponse.java
Outdated
Show resolved
Hide resolved
...java/org/elasticsearch/action/admin/cluster/storedscripts/GetScriptContextResponseTests.java
Show resolved
Hide resolved
...main/java/org/elasticsearch/action/admin/cluster/storedscripts/GetScriptContextResponse.java
Outdated
Show resolved
Hide resolved
...va/org/elasticsearch/action/admin/cluster/storedscripts/TransportGetScriptContextAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/client/ClusterAdminClient.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/ScriptService.java
Outdated
Show resolved
Hide resolved
…ode, do not use master action, use set for getContextNames
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
…e/47411-painless-script-context-rest_1_name
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Oct 16, 2019
Adds `GET /_script_context`, returning a `contexts` object with each
available context as a key whose value is an empty object. eg.
```
{
"contexts": {
"aggregation_selector": {},
"aggs": {},
"aggs_combine": {},
...
}
}
```
refs: elastic#47411
stu-elastic
added a commit
that referenced
this pull request
Oct 17, 2019
Adds `GET /_script_context`, returning a `contexts` object with each
available context as a key whose value is an empty object. eg.
```
{
"contexts": {
"aggregation_selector": {},
"aggs": {},
"aggs_combine": {},
...
}
}
```
refs: #47411
Contributor
|
@stu-elastic Please remember to label all PRs with change type, area and version labels. This is important for the release notes process as well as letting people looking at the PR know quickly where it is targetting |
Contributor
|
I've added some labels I think are appropriate but please check and amend as necessary |
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scripting: get context names REST API
Adds
GET /_script_context, returning acontextsobject with eachavailable context as a key whose value is an empty object. eg.
refs: #47411