Add snapshot support to distribution download plugin#47837
Merged
rjernst merged 7 commits intoelastic:masterfrom Oct 11, 2019
Merged
Add snapshot support to distribution download plugin#47837rjernst merged 7 commits intoelastic:masterfrom
rjernst merged 7 commits intoelastic:masterfrom
Conversation
The distribution download plugin which handles finding built distributions for testing currently only knows how to find locally built snapshots. When an external Elasticsearch plugin uses build-tools, these snapshots do not exist. This commit extends the download plugin so it pulls from the Elastic snapshots service when used outside of the Elasticsearch repository. closes elastic#47123
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Member
Author
|
@elasticmachine run elasticsearch-ci/oss-distro-docs |
mark-vieira
approved these changes
Oct 10, 2019
Contributor
mark-vieira
left a comment
There was a problem hiding this comment.
Couple minor comments, otherwise LGTM.
buildSrc/src/main/java/org/elasticsearch/gradle/DistributionDownloadPlugin.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/ElasticsearchDistribution.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/DistributionDownloadPlugin.java
Show resolved
Hide resolved
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
Member
Author
|
@elasticmachine run elasticsearch-ci/1 |
rjernst
added a commit
that referenced
this pull request
Oct 11, 2019
The distribution download plugin which handles finding built distributions for testing currently only knows how to find locally built snapshots. When an external Elasticsearch plugin uses build-tools, these snapshots do not exist. This commit extends the download plugin so it pulls from the Elastic snapshots service when used outside of the Elasticsearch repository. closes #47123
howardhuanghua
pushed a commit
to TencentCloudES/elasticsearch
that referenced
this pull request
Oct 14, 2019
The distribution download plugin which handles finding built distributions for testing currently only knows how to find locally built snapshots. When an external Elasticsearch plugin uses build-tools, these snapshots do not exist. This commit extends the download plugin so it pulls from the Elastic snapshots service when used outside of the Elasticsearch repository. closes elastic#47123
Contributor
|
Would be nice to port it back to 7.4.x - 7.4.2 doesn't contain it and prevents the build from even starting (bails on bwcVersions lookup in DistributionDownloadPlugin). |
Member
Author
|
7.4 likely will not see another release since 7.5 is the current minor release. And we don't ever re-release a version, so at best it would be 7.4.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The distribution download plugin which handles finding built
distributions for testing currently only knows how to find locally built
snapshots. When an external Elasticsearch plugin uses build-tools, these
snapshots do not exist. This commit extends the download plugin so it
pulls from the Elastic snapshots service when used outside of the
Elasticsearch repository.
closes #47123