Remove types from GeoShapeQueryBuilder#47792
Merged
romseygeek merged 6 commits intoelastic:masterfrom Oct 23, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
cbuescher
approved these changes
Oct 22, 2019
Member
cbuescher
left a comment
There was a problem hiding this comment.
LGTM, left a comment regarding leaving/modifying javadoc. Change and leave or ignore, I'm fine either way.
| * @param indexedShapeType | ||
| * Index type of the indexed Shapes | ||
| * @deprecated use {@link #GeoShapeQueryBuilder(String, String)} instead | ||
| */ |
Member
There was a problem hiding this comment.
Maybe keep and adapt the docs? Or do you think its not useful or self-explanatory?
Contributor
Author
There was a problem hiding this comment.
I added this back in, had removed it by mistake. Thanks!
…act-geo-querybuilder
…uerybuilder' into types-removal/abstract-geo-querybuilder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the unused 'shapeType' information from
AbstractGeoQueryBuilderand its implementations.
Related to #41059