Skip to content

Change policy_id to list type in slm.get_lifecycle#47766

Merged
russcam merged 1 commit intomasterfrom
russcam-patch-17
Oct 24, 2019
Merged

Change policy_id to list type in slm.get_lifecycle#47766
russcam merged 1 commit intomasterfrom
russcam-patch-17

Conversation

@russcam
Copy link
Copy Markdown
Contributor

@russcam russcam commented Oct 9, 2019

This commit changes the REST API spec slm.get_lifecycle's polict_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765

This commit changes the REST API spec slm.get_lifecycle's polict_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765
Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakrone dakrone added the :Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. label Oct 10, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@russcam russcam merged commit 19b9fb6 into master Oct 24, 2019
@russcam
Copy link
Copy Markdown
Contributor Author

russcam commented Oct 24, 2019

@dakrone should this also be ported to 7.x, 7.4, 7.5 ?

@dakrone
Copy link
Copy Markdown
Member

dakrone commented Oct 24, 2019

@russcam yes, do you want me to do it or do you want to do it?

@russcam
Copy link
Copy Markdown
Contributor Author

russcam commented Oct 24, 2019

@dakrone no worries, I got it. thanks!

russcam added a commit that referenced this pull request Oct 24, 2019
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765
russcam added a commit that referenced this pull request Oct 24, 2019
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765
russcam added a commit that referenced this pull request Oct 24, 2019
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765
@colings86 colings86 deleted the russcam-patch-17 branch May 27, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. v7.4.2 v7.5.0 v7.6.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

policy_id type in Get Snapshot Lifecycle API REST spec should be list

4 participants