Separate SLM stop/start/status API from ILM#47710
Conversation
This separates a start/stop/status API for SLM from being tied to ILM's operation mode. These APIs look like: ``` POST /_slm/stop POST /_slm/start GET /_slm/status ``` This allows administrators to have fine-grained control over preventing periodic snapshots and deletions while performing cluster maintenance. Relates to elastic#43663
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
|
I'll do a full review of this very soon - are we concerned that this changes the behavior of the ILM start/stop API from 7.4, in that it no longer starts/stops both ILM and SLM? |
|
@gwbrown I'm not really sure, I'm not too concerned, but it does mean that we should probably put a notice about this into the migration guide, what are your thoughts? |
AthenaEryma
left a comment
There was a problem hiding this comment.
Left a couple minor comments, LGTM otherwise - no need for another round of review.
The new APIs need HLRC support, but I can add that in a follow-up PR.
x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/OperationModeUpdateTask.java
Outdated
Show resolved
Hide resolved
|
I opened #47749 for the test failure (unrelated) @elasticmachine run elasticsearch-ci/2 |
* Separate SLM stop/start/status API from ILM This separates a start/stop/status API for SLM from being tied to ILM's operation mode. These APIs look like: ``` POST /_slm/stop POST /_slm/start GET /_slm/status ``` This allows administrators to have fine-grained control over preventing periodic snapshots and deletions while performing cluster maintenance. Relates to #43663 * Allow going from RUNNING to STOPPED * Align with the OperationMode rules * Fix slmStopping method * Make OperationModeUpdateTask constructor private * Wipe snapshots better in test
|
Hi @dakrone @gwbrown it appears the rest api specification files are missing for these API's cc @elastic/es-clients |
|
@Mpdreamz I've implemented the specs locally for the .NET client: |
Was originally missed in PR elastic#47710
…ts. (elastic#49759) Was originally missed in PR elastic#47710
This separates a start/stop/status API for SLM from being tied to ILM's
operation mode. These APIs look like:
This allows administrators to have fine-grained control over preventing
periodic snapshots and deletions while performing cluster maintenance.
Relates to #43663