Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Monitoring) |
Collaborator
|
Pinging @elastic/es-security (:Security/Authorization) |
Contributor
|
Changes look good, however, I would like a review from @elastic/es-security before merging and backporting. |
bizybot
reviewed
Oct 7, 2019
...core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStore.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @bizybot. Could you please take a look at the latest changes and see if they align with your suggestions? Thanks! |
Contributor
Contributor
Author
|
@tvernum Polite bump on review. Thanks! |
Contributor
|
@elasticmachine update branch |
Contributor
|
This looks good to me, once we get the tests passing. |
tvernum
approved these changes
Dec 6, 2019
This was referenced Dec 6, 2019
cachedout
added a commit
to cachedout/elasticsearch
that referenced
this pull request
Dec 6, 2019
* Add test for APM beats index perms * Grant monitoring index privs to apm_system user * Review feedback * Fix compilation problem
cachedout
added a commit
to cachedout/elasticsearch
that referenced
this pull request
Dec 6, 2019
* Add test for APM beats index perms * Grant monitoring index privs to apm_system user * Review feedback * Fix compilation problem
cachedout
added a commit
that referenced
this pull request
Dec 9, 2019
cachedout
added a commit
that referenced
this pull request
Dec 9, 2019
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
* Add test for APM beats index perms * Grant monitoring index privs to apm_system user * Review feedback * Fix compilation problem
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue described here: elastic/apm-server#2708
This extends changes made here to the apm_system user: #40876
(This was re-opened against master per a comment by @jakelandis in #47302)