Remove types from explain API#46926
Merged
romseygeek merged 5 commits intoelastic:masterfrom Sep 23, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search |
jtibshirani
reviewed
Sep 20, 2019
Contributor
jtibshirani
left a comment
There was a problem hiding this comment.
This looks good to me, I just had a small comment.
| ExplainRequest(StreamInput in) throws IOException { | ||
| super(in); | ||
| type = in.readString(); | ||
| if (in.getVersion().before(Version.V_8_0_0)) { |
Contributor
There was a problem hiding this comment.
To be safe, we could read the type but assert that it is _doc (similarly to what we did in #42198).
Contributor
Author
|
@elasticmachine update branch |
jtibshirani
approved these changes
Sep 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need a type to get the source of a document, so we can remove it from
the explain API as well.
Relates to #41059