Skip to content

[DOCS] Reformat split index API docs#46713

Merged
jrodewig merged 8 commits intoelastic:masterfrom
jrodewig:split-index-reformat
Oct 4, 2019
Merged

[DOCS] Reformat split index API docs#46713
jrodewig merged 8 commits intoelastic:masterfrom
jrodewig:split-index-reformat

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

Reformats the split API docs to align with the new API reference template.

Relates to #43765.

@jrodewig jrodewig added >docs General docs changes :Data Management/Indices APIs DO NOT USE. Use ":Distributed/Indices APIs" or ":StorageEngine/Templates" instead. v8.0.0 v7.3.0 v7.4.0 v7.5.0 labels Sep 13, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig added v7.4.1 and removed v7.4.0 labels Sep 27, 2019
@jrodewig jrodewig requested review from debadair and szabosteve and removed request for debadair October 3, 2019 20:06
Copy link
Copy Markdown
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple editorial comments, but otherwise LGTM.

Comment on lines +32 to +34
To split an index,
the index must be marked as read-only
and have a <<cluster-health,cluster health>> status of `green`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads as if it's the index that needs to be green, rather than the cluster. If you change the shrink prereqs, I'd make a similar change here:

Before you can split an index:

  • The index must be read-only.
  • The <<cluster-health, cluster health>> status must be green.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @debadair. I used this format with 6f981b9.

@@ -52,9 +103,9 @@ Splitting works as follows:
* Finally, it recovers the target index as though it were a closed index which
had just been re-opened.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like with shrinking, referring to splitting as "it" is a bit odd. If you make changes there, I'd make parallel changes here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 6f981b9.

==== Wait For Active Shards

[[split-wait-active-shards]]
==== Wait For active shards
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase for?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed with 6f981b9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Indices APIs DO NOT USE. Use ":Distributed/Indices APIs" or ":StorageEngine/Templates" instead. >docs General docs changes v7.3.0 v7.4.1 v7.5.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants