Add more context to QueryShardContext#46584
Merged
jimczi merged 1 commit intoelastic:masterfrom Sep 11, 2019
Merged
Conversation
This change adds an IndexSearcher and the node's BigArrays in the QueryShardContext. It's a spin off of elastic#46527 as this change is required to allow aggregation builder to solely use the query shard context. Relates elastic#46523
Collaborator
|
Pinging @elastic/es-search |
javanna
reviewed
Sep 11, 2019
| try (IndexReader indexReader = DirectoryReader.open(indexWriter)) { | ||
| final long absoluteStartMillis = System.currentTimeMillis(); | ||
| final IndexSearcher searcher = new IndexSearcher(indexReader); | ||
| searcher.setQueryCache(null); |
Contributor
There was a problem hiding this comment.
just a small question on this. where did we do setQueryCache(null) before?
Contributor
Author
There was a problem hiding this comment.
It shouldn't be required, I added this by precaution but I can remove it
Contributor
There was a problem hiding this comment.
I see, it's fine by me, I was just curious
Contributor
There was a problem hiding this comment.
and what about the places where we were previously setting the query cache and the policy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an IndexSearcher and the node's BigArrays in the QueryShardContext.
It's a spin off of #46527 as this change is required to allow aggregation builder to solely use the
query shard context.
Relates #46523