Reindex and friends fail on RED shards#45830
Merged
henningandersen merged 6 commits intoelastic:masterfrom Nov 18, 2019
Merged
Conversation
Reindex, update by query and delete by query would silently disregard RED/unavailable shards, thus not copying, updating or deleting matching data in those shards. Now use `allow_partial_search_results=false` to ensure these operations fail if the search crosses an unavailable chard. Relates elastic#45739 and elastic#42612
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
We may want to consider still supporting running reindex with allow_partial_search_results=true, since this could be a partial recovery path for indices that are missing shards |
Contributor
Author
|
@elasticmachine update branch |
|
After some investigating, I can't find a use case for using allow_partial_search_results=true for reindex. I think there are valid search use cases for the allow_partial_search_results option, however, when upgrading or migrating data (with reindex), I would focus on correcting the red shards before running reindex. |
This reverts commit 9cb38ae.
…w_partial_search_results
Contributor
Author
|
Thanks @zuketo , as agreed on another channel, I have now reverted the ability to run with |
henningandersen
added a commit
that referenced
this pull request
Nov 18, 2019
Reindex, update by query and delete by query would silently disregard RED/unavailable shards, thus not copying, updating or deleting matching data in those shards. Now use `allow_partial_search_results=false` to ensure these operations fail if the search crosses an unavailable chard. Added the option to explicitly specify `allow_partial_search_results=true` for reindex only (seemed too strange for update/delete by query). Relates #45739 and #42612
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reindex, update by query and delete by query would silently disregard
RED/unavailable shards, thus not copying, updating or deleting matching
data in those shards. Now use
allow_partial_search_results=falsetoensure these operations fail if the search crosses an unavailable chard.
Added the option to explicitly specify
allow_partial_search_results=truefor reindex only (seemed too strange for update/delete by query).
Relates #45739 and #42612