Call the new _estimate_memory_usage API endpoint on df analytics _start#45536
Merged
przemekwitek merged 3 commits intoelastic:masterfrom Aug 19, 2019
Merged
Conversation
80402eb to
66d6172
Compare
6 tasks
66d6172 to
2df1f74
Compare
Collaborator
|
Pinging @elastic/ml-core |
2df1f74 to
b5ec18f
Compare
Author
|
run elasticsearch-ci/1 |
Contributor
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
Looks good! Left a few minor comments
.../src/main/java/org/elasticsearch/xpack/ml/action/TransportStartDataFrameAnalyticsAction.java
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/xpack/ml/action/TransportStartDataFrameAnalyticsAction.java
Outdated
Show resolved
Hide resolved
...n/java/org/elasticsearch/xpack/ml/dataframe/process/MemoryUsageEstimationProcessManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/xpack/ml/action/TransportStartDataFrameAnalyticsAction.java
Outdated
Show resolved
Hide resolved
Author
|
run elasticsearch-ci/1 |
2 similar comments
Author
|
run elasticsearch-ci/1 |
Author
|
run elasticsearch-ci/1 |
przemekwitek
pushed a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Aug 19, 2019
przemekwitek
pushed a commit
that referenced
this pull request
Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the new _estimate_memory_usage API endpoint into df analytics.
_estimate_memory_usage is called early during df analytics _start in order to detect whether user-provided model memory limit is sufficient taking into account memory usage estimation. If not, error is thrown and the user can retry the request with different (higher) value of model_memory_limit.
Relates #44699
Closes #45544