Only execute one final reduction in InternalAutoDateHistogram#45359
Merged
polyfractal merged 4 commits intoelastic:masterfrom Aug 12, 2019
Merged
Only execute one final reduction in InternalAutoDateHistogram#45359polyfractal merged 4 commits intoelastic:masterfrom
polyfractal merged 4 commits intoelastic:masterfrom
Conversation
Because auto-date-histo can perform multiple reductions while merging buckets, we need to ensure that the intermediate reductions are done with a `finalReduce` set to false to prevent Pipeline aggs from generating their output. Once all the buckets have been merged and the output is stable, a mostly-noop reduction can be performed which will allow pipelines to generate their output.
Collaborator
|
Pinging @elastic/es-analytics-geo |
pcsanwald
approved these changes
Aug 8, 2019
Contributor
pcsanwald
left a comment
There was a problem hiding this comment.
one small comment but the rest of it LGTM
...n/java/org/elasticsearch/search/aggregations/bucket/histogram/InternalAutoDateHistogram.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 12, 2019 11:10
Contributor
Author
|
@elasticmachine update branch |
polyfractal
pushed a commit
that referenced
this pull request
Aug 12, 2019
Because auto-date-histo can perform multiple reductions while merging buckets, we need to ensure that the intermediate reductions are done with a `finalReduce` set to false to prevent Pipeline aggs from generating their output. Once all the buckets have been merged and the output is stable, a mostly-noop reduction can be performed which will allow pipelines to generate their output.
This was referenced Aug 12, 2019
Contributor
Author
|
I reverted this commit because Unsure of the cause, but it was starting to look like it's not just a test bug but an actual problem with the PR. Will revisit and open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because auto-date-histo can perform multiple reductions while merging buckets, we need to ensure that the intermediate reductions are done with a
finalReduceset to false to prevent Pipeline aggs from generating their output.This is done by creating a "fake" non-final reduce context for the intermediate merging. Once all the buckets have been merged and the output is stable, a mostly-noop final reduction can be performed which will allow pipelines to generate their output.
Closes #44914