Implement ml/data_frame/analytics/_estimate_memory_usage API endpoint#45188
Merged
przemekwitek merged 11 commits intoelastic:masterfrom Aug 13, 2019
Merged
Implement ml/data_frame/analytics/_estimate_memory_usage API endpoint#45188przemekwitek merged 11 commits intoelastic:masterfrom
przemekwitek merged 11 commits intoelastic:masterfrom
Conversation
2400192 to
0e6a285
Compare
6 tasks
0e6a285 to
b2a07db
Compare
Collaborator
|
Pinging @elastic/ml-core |
droberts195
reviewed
Aug 9, 2019
droberts195
left a comment
There was a problem hiding this comment.
Thanks for doing this - I know it's a lot of changes for what seems like it should be simple functionality.
I just left a few minor comments and questions.
...gin/core/src/main/java/org/elasticsearch/xpack/core/ml/action/EstimateMemoryUsageAction.java
Outdated
Show resolved
Hide resolved
...n/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/DataFrameAnalyticsConfig.java
Outdated
Show resolved
Hide resolved
9e27f96 to
0b29277
Compare
|
Jenkins run elasticsearch-ci/1 |
744ccef to
bdb45bd
Compare
Author
|
run elasticsearch-ci/2 |
added 8 commits
August 12, 2019 21:05
This reverts commit 77af46370605f9291ef05c5bf08ba4a21df20868.
…test cases from build.gradle as possible.
7a69527 to
9c9f76f
Compare
…nse's fields optional.
added 2 commits
August 13, 2019 10:58
* Add unit tests for AbstractNativeProcess
przemekwitek
pushed a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Aug 13, 2019
przemekwitek
pushed a commit
that referenced
this pull request
Aug 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces ml/data_frame/analytics/_estimate_memory_usage API endpoint that will be used to obtain memory usage estimation even before the analysis gets started.
Relates #44699