Merged
Conversation
Add the maven repository of the shibboleth project in a couple of places ( x-pack:plugin and x-pack:qa subprojects ) so that we can upgrade opensaml and related dependencies to the latest version Relates: elastic#44947
Collaborator
|
Pinging @elastic/es-security |
Collaborator
|
Pinging @elastic/es-core-infra |
tvernum
approved these changes
Jul 30, 2019
Contributor
tvernum
left a comment
There was a problem hiding this comment.
LGTM, excepting the test failures
x-pack/build.gradle
Outdated
|
|
||
| subprojects { | ||
|
|
||
| // We define a specific reposiroty for opensaml since the shibboleth project doesn't publish to maven central and the |
Contributor
There was a problem hiding this comment.
Suggested change
| // We define a specific reposiroty for opensaml since the shibboleth project doesn't publish to maven central and the | |
| // We define a specific repository for opensaml since the shibboleth project doesn't publish to maven central and the |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
jkakavas
commented
Oct 4, 2019
| // see https://github.com/apache/santuario-java/blob/e79f1fe4192de73a975bc7246aee58ed0703343d/src/main/java/org/apache/xml/security/utils/JavaUtils.java#L205-L220 | ||
| // and https://git.shibboleth.net/view/?p=java-opensaml.git;a=blob;f=opensaml-xmlsec-impl/src/main/java/org/opensaml/xmlsec/signature/impl/SignatureMarshaller.java;hb=db0eaa64210f0e32d359cd6c57bedd57902bf811#l52 | ||
| // which uses it in the opensaml-xmlsec-impl | ||
| permission java.security.SecurityPermission "org.apache.xml.security.register"; |
Contributor
Author
There was a problem hiding this comment.
This change removed the doPrivileged() in xmlsec, which in turn means that every class in the whole execution thread needs the java.security.SecurityPermission "org.apache.xml.security.register"; permission for registering the xml security algorithms. :(
Contributor
Author
|
@elasticmachine test this please |
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Nov 23, 2019
Add a mirror of the maven repository of the shibboleth project and upgrade opensaml and related dependencies to the latest version available version Resolves: elastic#44947
jkakavas
added a commit
that referenced
this pull request
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the maven repository of the shibboleth project in a couple of
places ( x-pack:plugin and x-pack:qa subprojects ) so that we can
upgrade opensaml and related dependencies to the latest version
Resolves: #44947