Skip to content

Skip local recovery for closed or frozen indices#44887

Merged
dnhatn merged 2 commits intoelastic:peer-recovery-retention-leasesfrom
dnhatn:skip-local-recovery
Jul 30, 2019
Merged

Skip local recovery for closed or frozen indices#44887
dnhatn merged 2 commits intoelastic:peer-recovery-retention-leasesfrom
dnhatn:skip-local-recovery

Conversation

@dnhatn
Copy link
Copy Markdown
Member

@dnhatn dnhatn commented Jul 25, 2019

For closed and frozen indices, we should not recover shard locally up to the global checkpoint before performing peer recovery for that copy might be offline when the index was closed/frozen.

Relates #43463
Closes #44855

@dnhatn dnhatn added >enhancement :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. labels Jul 25, 2019
@dnhatn dnhatn requested a review from ywelsch July 25, 2019 23:14
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed

Copy link
Copy Markdown
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Copy Markdown
Member Author

dnhatn commented Jul 30, 2019

@elasticmachine update branch

@dnhatn
Copy link
Copy Markdown
Member Author

dnhatn commented Jul 30, 2019

Thanks @ywelsch.

@dnhatn dnhatn merged commit 907bb55 into elastic:peer-recovery-retention-leases Jul 30, 2019
@dnhatn dnhatn deleted the skip-local-recovery branch July 30, 2019 14:45
dnhatn added a commit that referenced this pull request Jul 30, 2019
For closed and frozen indices, we should not recover shard locally up to
the global checkpoint before performing peer recovery for that copy
might be offline when the index was closed/frozen.

Relates #43463
Closes #44855
DaveCTurner added a commit that referenced this pull request Aug 2, 2019
@DaveCTurner
Copy link
Copy Markdown
Member

The backport needed the plugin adding to the transport client too (https://gradle.com/s/6s3bqbpwbjtpo). I just pushed this fix in 14bba51. This is trappy because there's no transport client in master to worry about.

@dnhatn
Copy link
Copy Markdown
Member Author

dnhatn commented Aug 2, 2019

Thanks @DaveCTurner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. >enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants