[DOCS] Fixes terms in HLRC data frame transform APIs#44838
Merged
lcawl merged 3 commits intoelastic:masterfrom Jul 25, 2019
Merged
[DOCS] Fixes terms in HLRC data frame transform APIs#44838lcawl merged 3 commits intoelastic:masterfrom
lcawl merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-features |
Collaborator
|
Pinging @elastic/es-docs |
Collaborator
|
Pinging @elastic/ml-core |
droberts195
approved these changes
Jul 25, 2019
droberts195
left a comment
There was a problem hiding this comment.
LGTM assuming you're happy with the name of the anchor I asked about
| include::ilm/remove_lifecycle_policy_from_index.asciidoc[] | ||
|
|
||
| == Data Frame APIs | ||
| [[_data_frame_transform_apis]] |
There was a problem hiding this comment.
Is this anchor supposed to start with an underscore?
Contributor
Author
There was a problem hiding this comment.
Yes, that's what it defaults to automatically at the moment. I think we'll want to ultimately change it, but didn't want to break any current bookmarks.
lcawl
added a commit
that referenced
this pull request
Jul 25, 2019
lcawl
added a commit
that referenced
this pull request
Jul 25, 2019
lcawl
added a commit
that referenced
this pull request
Jul 25, 2019
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the content in the Java REST Client > Java High Level REST Client > Data Frame APIs documentation (https://www.elastic.co/guide/en/elasticsearch/client/java-rest/master/_data_frame_apis.html) such that it uses appropriate attributes for the terminology.
It also fixes the titles to follow sentence style capitalization.