Asynchronously connect to remote clusters#44825
Merged
ywelsch merged 10 commits intoelastic:masterfrom Jul 25, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
I've left a few questions mainly around the need for a number of uses of the mutex.
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Outdated
Show resolved
Hide resolved
ywelsch
commented
Jul 25, 2019
Contributor
Author
ywelsch
left a comment
There was a problem hiding this comment.
@original-brownbear I have reworked the synchronization bit, and moved to a list instead of a blocking queue (I find it easier to think about it in terms of a simple list + mutex). Can you have another look?
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 (unrelated watcher issue) |
original-brownbear
approved these changes
Jul 25, 2019
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, thanks @ywelsch :)
server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
Contributor
|
Jenkins run elasticsearch-ci/bwc |
6 tasks
ywelsch
added a commit
that referenced
this pull request
Jul 25, 2019
Refactors RemoteClusterConnection so that it no longer blockingly connects to remote clusters. Relates to #40150
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
Refactors RemoteClusterConnection so that it no longer blockingly connects to remote clusters. Relates to #40150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
RemoteClusterConnectionso that it no longer blockingly connects to remote clusters.Relates to #40150