Add option to filter ILM explain response#44777
Merged
AthenaEryma merged 6 commits intoelastic:masterfrom Jul 25, 2019
Merged
Conversation
In order to make it easier to interpret the output of the ILM Explain API, this commit adds two request parameters to that API: - `only_managed`, which causes the response to only contain indices which have `index.lifecycle.name` set - `only_errors`, which causes the response to contain only indices in an ILM error state "Error state" is defined as either being in the `ERROR` step or having `index.lifecycle.name` set to a policy that does not exist.
Collaborator
|
Pinging @elastic/es-core-features |
AthenaEryma
commented
Jul 23, 2019
| * {@link #indices(String...)} method | ||
| */ | ||
| public class ExplainLifecycleRequest extends ClusterInfoRequest<ExplainLifecycleRequest> { | ||
| private static final Version FILTERS_INTRODUCED_VERSION = Version.V_8_0_0; |
Contributor
Author
There was a problem hiding this comment.
TODO: Update this in the backport and in master after merging the backport.
Contributor
Author
There was a problem hiding this comment.
Updated the serialization version in a76242d now that the backport has been merged.
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 Opened #44778 for the failure. |
dakrone
approved these changes
Jul 24, 2019
Member
dakrone
left a comment
There was a problem hiding this comment.
This LGTM, do you think it's worth adding something to the REST tests for ILM that uses it? Up to you either way.
Contributor
Author
|
Good idea @dakrone, I've added a couple basic tests. |
AthenaEryma
added a commit
to AthenaEryma/elasticsearch
that referenced
this pull request
Jul 25, 2019
In order to make it easier to interpret the output of the ILM Explain API, this commit adds two request parameters to that API: - `only_managed`, which causes the response to only contain indices which have `index.lifecycle.name` set - `only_errors`, which causes the response to contain only indices in an ILM error state "Error state" is defined as either being in the `ERROR` step or having `index.lifecycle.name` set to a policy that does not exist.
AthenaEryma
added a commit
that referenced
this pull request
Jul 26, 2019
In order to make it easier to interpret the output of the ILM Explain API, this commit adds two request parameters to that API: - `only_managed`, which causes the response to only contain indices which have `index.lifecycle.name` set - `only_errors`, which causes the response to contain only indices in an ILM error state "Error state" is defined as either being in the `ERROR` step or having `index.lifecycle.name` set to a policy that does not exist.
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
In order to make it easier to interpret the output of the ILM Explain API, this commit adds two request parameters to that API: - `only_managed`, which causes the response to only contain indices which have `index.lifecycle.name` set - `only_errors`, which causes the response to contain only indices in an ILM error state "Error state" is defined as either being in the `ERROR` step or having `index.lifecycle.name` set to a policy that does not exist.
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make it easier to interpret the output of the ILM Explain
API, this commit adds two request parameters to that API:
only_managed, which causes the response to only contain indiceswhich have
index.lifecycle.namesetonly_errors, which causes the response to contain only indices in anILM error state
"Error state" is defined as either being in the
ERRORstep or havingindex.lifecycle.nameset to a policy that does not exist.Closes #44189