Deprecation messages with the same key but different x-opaque-id are allowed (#44587)#44587
Merged
pgomulka merged 3 commits intoelastic:masterfrom Jul 22, 2019
Merged
Conversation
We should allow to log the same deprecation type (basing on key) to be logged if X-Opaque-ID is logged.
Collaborator
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
Jul 18, 2019
|
|
||
| public String getXOpaqueId(Set<ThreadContext> threadContexts) { | ||
| return threadContexts.stream() | ||
| .filter(t -> t.isClosed() == false) |
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jul 22, 2019
…allowed (elastic#44587) Deprecation logger was filtering log entries by key, that means that if two log messages with the same key are logged from different users, then the second log messages will be filtered. This change allows to log deprecation message with the same key by different users. relates elastic#41354
pgomulka
added a commit
that referenced
this pull request
Jul 22, 2019
…allowed backport(#44587) #44682 Deprecation logger was filtering log entries by key, that means that if two log messages with the same key are logged from different users, then the second log messages will be filtered. This change allows to log deprecation message with the same key by different users. relates #41354 backport #44587
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecation logger was filtering log entries by key, that means that if two log messages with the same key are logged from different users, then the second log messages will be filtered.
This change allows to log deprecation message with the same key by different users.
relates #41354