Improve handshake failure messages#44485
Merged
DaveCTurner merged 1 commit intoelastic:masterfrom Jul 17, 2019
Merged
Conversation
Today we report an exception on a handshake failure (e.g. cluster name mismatch) but the message does not include all the details of the mismatch. If the mismatch is something subtle like `my-cluster` instead of `my_cluster` then we cannot diagnose this from the message alone. This commit adds the details of the local cluster to the message, along with the details of the remote cluster, improving the utility of the exception message if reported in isolation.
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
|
Super cool. Looking forward to this change. You have no idea how many students mistype cluster names :) |
original-brownbear
approved these changes
Jul 17, 2019
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM good one :D
DaveCTurner
added a commit
that referenced
this pull request
Jul 17, 2019
Today we report an exception on a handshake failure (e.g. cluster name mismatch) but the message does not include all the details of the mismatch. If the mismatch is something subtle like `my-cluster` instead of `my_cluster` then we cannot diagnose this from the message alone. This commit adds the details of the local cluster to the message, along with the details of the remote cluster, improving the utility of the exception message if reported in isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we report an exception on a handshake failure (e.g. cluster name
mismatch) but the message does not include all the details of the mismatch. If
the mismatch is something subtle like
my-clusterinstead ofmy_clusterthenwe cannot diagnose this from the message alone. This commit adds the details of
the local cluster to the message, along with the details of the remote cluster,
improving the utility of the exception message if reported in isolation.