Skip to content

Refresh translog stats after translog trimming in NoOpEngine#43825

Merged
tlrx merged 2 commits intoelastic:masterfrom
tlrx:refresh-translog-stats-after-trimming
Jul 3, 2019
Merged

Refresh translog stats after translog trimming in NoOpEngine#43825
tlrx merged 2 commits intoelastic:masterfrom
tlrx:refresh-translog-stats-after-trimming

Conversation

@tlrx
Copy link
Copy Markdown
Member

@tlrx tlrx commented Jul 1, 2019

This pull request changes NoOpEngine so that it refreshes its translog stats once translog is trimmed.

Relates #43156

@tlrx tlrx added >enhancement :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.3.0 labels Jul 1, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed

Copy link
Copy Markdown
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Jul 1, 2019

@elasticmachine run elasticsearch-ci/1

@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Jul 2, 2019

@elasticmachine update branch

@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Jul 2, 2019

@elasticmachine run elasticsearch-ci/1

@tlrx tlrx merged commit d87c9fd into elastic:master Jul 3, 2019
@tlrx tlrx deleted the refresh-translog-stats-after-trimming branch July 3, 2019 06:39
@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Jul 3, 2019

Thanks @dnhatn and @ywelsch

tlrx added a commit that referenced this pull request Jul 3, 2019
This commit changes NoOpEngine so that it refreshes its translog 
stats once translog is trimmed.

Relates #43156
@tlrx tlrx mentioned this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Engine Anything around managing Lucene and the Translog in an open shard. >enhancement v7.3.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants