Skip to content

[DOCS] Rewrite boosting query#43647

Merged
jrodewig merged 2 commits intoelastic:masterfrom
jrodewig:rewrite-boosting-query
Jun 28, 2019
Merged

[DOCS] Rewrite boosting query#43647
jrodewig merged 2 commits intoelastic:masterfrom
jrodewig:rewrite-boosting-query

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

Rewrites the boosting query to use the new query format.

This is part of #40977, an effort to standardize documentation for query types.

Before

Before image Boosting-before

After

After image Boosting-after

@jrodewig jrodewig added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.0.2 v7.3.0 v7.1.2 v7.2.1 labels Jun 26, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs

Copy link
Copy Markdown
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another great rewrite, I left a question regarding the necessity of mentioning the regular "boost" factor here so prominently. Would like to hear your thoughts.

"negative" : {
"term" : {
"field2" : "value2"
"text" : "pie tart fruit crumble tree"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"negative_boost" : 0.2
"negative_boost" : 0.5,
"boost" : 1.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same "boost" factor that we have with every query? In that case I wonder if it complicates the discussion at this point since the "negative_boost" is the thing specific for this query. I was under the impression that we document the "global" boost factor of each query clause elsewhere. Maybe worth reconsidering it here.

Copy link
Copy Markdown
Contributor Author

@jrodewig jrodewig Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the review @cbuescher.

This is an excellent point. I removed documentation for the generic boost parameter with the boosting query with 2f82523.

I've not started it yet, but I am planning to document the boost parameter with its own page with #40977.

Copy link
Copy Markdown
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM

@jrodewig jrodewig merged commit 623a5dd into elastic:master Jun 28, 2019
@jrodewig jrodewig deleted the rewrite-boosting-query branch June 28, 2019 12:35
jrodewig added a commit that referenced this pull request Jun 28, 2019
jrodewig added a commit that referenced this pull request Jun 28, 2019
jrodewig added a commit that referenced this pull request Jun 28, 2019
jrodewig added a commit that referenced this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.2 v7.1.2 v7.2.1 v7.3.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants