Account soft deletes for committed segments#43126
Merged
dnhatn merged 1 commit intoelastic:masterfrom Jun 14, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Jun 13, 2019
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
LGTM. Can you follow-up with a PR that exposes stats about soft-deleted docs?
Member
Author
|
@ywelsch Thanks for reviewing. I've responded on the issue. |
dnhatn
added a commit
that referenced
this pull request
Jun 15, 2019
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments. Relates #43103
dnhatn
added a commit
that referenced
this pull request
Jun 15, 2019
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments. Relates #43103
dnhatn
added a commit
that referenced
this pull request
Jun 15, 2019
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments. Relates #43103
dnhatn
added a commit
that referenced
this pull request
Jun 17, 2019
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments. Relates #43103
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 3, 2019
Backport of elastic/elasticsearch#43126 This change fixes the delete count issue in segment stats where soft-deleted documents from committed segments are not accounted.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments.
Relates #43103