Fix timing issue in CcrRetentionLeaseIT#43054
Merged
dnhatn merged 2 commits intoelastic:masterfrom Jun 11, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
Thanks @jasontedor. |
dnhatn
added a commit
that referenced
this pull request
Jun 11, 2019
In these tests, we sleep for a small multiple of the renew interval, then check that the retention leases are not changed. If a renewal request takes longer than that interval because of GC or slow CI, then the retention leases are not the same as before sleep. With this change, we relax to assert that we eventually stop the renewable process. Closes #39509
dnhatn
added a commit
that referenced
this pull request
Jun 12, 2019
In these tests, we sleep for a small multiple of the renew interval, then check that the retention leases are not changed. If a renewal request takes longer than that interval because of GC or slow CI, then the retention leases are not the same as before sleep. With this change, we relax to assert that we eventually stop the renewable process. Closes #39509
dnhatn
added a commit
that referenced
this pull request
Jun 12, 2019
In these tests, we sleep for a small multiple of the renew interval, then check that the retention leases are not changed. If a renewal request takes longer than that interval because of GC or slow CI, then the retention leases are not the same as before sleep. With this change, we relax to assert that we eventually stop the renewable process. Closes #39509
dnhatn
added a commit
that referenced
this pull request
Jun 12, 2019
In these tests, we sleep for a small multiple of the renew interval, then check that the retention leases are not changed. If a renewal request takes longer than that interval because of GC or slow CI, then the retention leases are not the same as before sleep. With this change, we relax to assert that we eventually stop the renewable process. Closes #39509
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In these tests, we sleep for a small multiple of the renew interval, then check that the retention leases are not changed. If a renewal request takes longer than that interval because of GC or slow CI, then the retention leases are not the same as before sleep. With this change, we relax to assert that we eventually stop the renewable process.
See https://github.com/elastic/elasticsearch/issues/#issuecomment-498523485
Closes #39509