Remove usage of FileSwitchDirectory #42937
Merged
s1monw merged 13 commits intoelastic:masterfrom Jun 12, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
this becomes even more pressing with https://issues.apache.org/jira/browse/LUCENE-8853 |
jimczi
approved these changes
Jun 12, 2019
Contributor
jimczi
left a comment
There was a problem hiding this comment.
I left one question, LGTM otherwise
server/src/main/java/org/elasticsearch/index/store/FsDirectoryFactory.java
Show resolved
Hide resolved
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jun 12, 2019
s1monw
added a commit
that referenced
this pull request
Jun 12, 2019
We are still using `FileSwitchDirectory` in the case a user configures file based pre-load of mmaps. This is trappy for multiple reasons if the both directories used by `FileSwitchDirectory` point to the same filesystem directory. One issue is LUCENE-8835 that cause issues like #37111 - unless LUCENE-8835 isn't fixed we should not use it in elasticsearch. Instead we use a similar trick as we use for HybridFS and subclass mmap directory directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are still using
FileSwitchDirectoryin the case a user configures file based pre-load of mmaps. This is trappy for multiple reasons if the both directories used byFileSwitchDirectorypoint to the same filesystem directory. One issue is LUCENE-8835 that cause issues like #37111 - unless LUCENE-8835 isn't fixed we should not use it in elasticsearch. Instead we use a similar trick as we use for HybridFS and subclass mmap directory directly.