[ML Data Frame] Persist data frame after state changes#42347
Merged
davidkyle merged 1 commit intoelastic:masterfrom May 22, 2019
Merged
[ML Data Frame] Persist data frame after state changes#42347davidkyle merged 1 commit intoelastic:masterfrom
davidkyle merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core |
davidkyle
added a commit
that referenced
this pull request
May 22, 2019
davidkyle
added a commit
that referenced
this pull request
May 23, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An optimisation that would only allow the data frame state & stats to be persisted if the stats had changed meant state changes were not being persisted. The code is called only when state and stats should be persisted so the optimisation is now harmful.
Should solve the failure described in #42309 (comment)