Update max_concurrent_shard_request parameter docs#42227
Merged
javanna merged 7 commits intoelastic:masterfrom May 23, 2019
Merged
Update max_concurrent_shard_request parameter docs#42227javanna merged 7 commits intoelastic:masterfrom
javanna merged 7 commits intoelastic:masterfrom
Conversation
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to elastic#31206
Collaborator
|
Pinging @elastic/es-search |
Contributor
Author
|
run elasticsearch-ci/bwc |
jimczi
approved these changes
May 23, 2019
Contributor
jimczi
left a comment
There was a problem hiding this comment.
I left some comments, LGTM otherwise
|
|
||
| The request parameter `max_concurrent_shard_requests` can be used to control the | ||
| maximum number of concurrent shard requests the each sub search request will execute. | ||
| maximum number of concurrent shard requests the each sub search request will execute per node. |
Contributor
There was a problem hiding this comment.
nit: s/maximum number of concurrent shard requests the/maximum number of concurrent shard requests that/
| (e.g., a default request will hit all indices in a cluster which could cause shard request rejections | ||
| if the number of shards per node is high). This default is based on the number of | ||
| data nodes in the cluster but at most `256`.In certain scenarios parallelism isn't achieved through | ||
| if the number of shards per node is high). This default value is `5`.In certain scenarios searcparallelism isn't achieved through |
Contributor
There was a problem hiding this comment.
nit: s/In certain scenarios searcparallelism/In certain scenarios parallelism/
Contributor
Author
|
run elasticsearch-ci/bwc |
Contributor
Author
|
run elasticsearch-ci/default-distro |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to elastic#31206
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jun 11, 2019
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to elastic#31206
javanna
added a commit
that referenced
this pull request
Jun 12, 2019
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to #31206
javanna
added a commit
that referenced
this pull request
Jun 12, 2019
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to #31206
javanna
added a commit
that referenced
this pull request
Jun 12, 2019
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to #31206
javanna
added a commit
that referenced
this pull request
Jun 12, 2019
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to #31206
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the docs were outdated as they did not mention that the limit is
not per node. Also, The default value changed.
Relates to #31206