Address test failures for SmokeTestWatcherWithSecurityIT#42092
Merged
jakelandis merged 7 commits intoelastic:masterfrom May 24, 2019
Merged
Address test failures for SmokeTestWatcherWithSecurityIT#42092jakelandis merged 7 commits intoelastic:masterfrom
jakelandis merged 7 commits intoelastic:masterfrom
Conversation
There are likely multiple root causes to the seemingly random failures generated by SmokeTestWatcherWithSecurityIT. This commit un-mutes this this test, address one known cause and adds debug logging for this test. The known root cause for one failure is that we can have a Watch running that is reading data from an index. Before we stop Watcher we delete that index. If Watcher happens to execute after deletion of the index but before the stop of Watcher the test can fail. The fix here is to simply move the index deletion after the stop of Watcher. Related elastic#35361 Related elastic#30777 Related elastic#35361 Related elastic#33291 Related elastic#29893
Collaborator
|
Pinging @elastic/es-core-features |
jasontedor
reviewed
May 10, 2019
Member
jasontedor
left a comment
There was a problem hiding this comment.
I left a comment about the logging configuration.
| # custom properties | ||
| ####################################### | ||
|
|
||
| logger.watcher.name = org.elasticsearch.xpack.watcher |
Member
There was a problem hiding this comment.
I think it's enough to say setting 'logger.org.elasticsearch.xpack.watcher', 'debug' etc. instead of adding an entire extra configuration file?
Contributor
Author
There was a problem hiding this comment.
thanks @jasontedor , i wasn't aware that was possible. tested it and works great. fixed on 119322c
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
1 similar comment
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Contributor
Author
|
ci didn't kick in again ... closing and re-opening to kick off CI |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Address test failures for SmokeTestWatcherWithSecurityIT There are likely multiple root causes to the seemingly random failures generated by SmokeTestWatcherWithSecurityIT. This commit un-mutes this this test, address one known cause and adds debug logging for this test. The known root cause for one failure is that we can have a Watch running that is reading data from an index. Before we stop Watcher we delete that index. If Watcher happens to execute after deletion of the index but before the stop of Watcher the test can fail. The fix here is to simply move the index deletion after the stop of Watcher. Related elastic#35361 Related elastic#30777 Related elastic#33291 Related elastic#29893
Contributor
|
@jakelandis Is there anything left to backport? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are likely multiple root causes to the seemingly random failures
generated by SmokeTestWatcherWithSecurityIT. This commit un-mutes this
this test, address one known cause and adds debug logging for this test.
The known root cause for one failure is that we can have a Watch running
that is reading data from an index. Before we stop Watcher we delete that
index. If Watcher happens to execute after deletion of the index but before
the stop of Watcher the test can fail. The fix here is to simply move the
index deletion after the stop of Watcher.
Related #35361
Related #30777
Related #33291
Related #29893