[ML] relax set upgrade mode test to match what is guaranteed#41958
Merged
benwtrent merged 3 commits intoelastic:masterfrom May 8, 2019
Merged
[ML] relax set upgrade mode test to match what is guaranteed#41958benwtrent merged 3 commits intoelastic:masterfrom
benwtrent merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core |
Member
Author
|
run elasticsearch-ci/1 |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 8, 2019
…#41958) * [ML] relax set upgrade mode test to match what is guaranteed * removing unused import
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 8, 2019
…#41958) * [ML] relax set upgrade mode test to match what is guaranteed * removing unused import
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 8, 2019
…#41958) * [ML] relax set upgrade mode test to match what is guaranteed * removing unused import
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 8, 2019
…#41958) * [ML] relax set upgrade mode test to match what is guaranteed * removing unused import
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 8, 2019
…#41958) * [ML] relax set upgrade mode test to match what is guaranteed * removing unused import
This was referenced May 8, 2019
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 9, 2019
…rsing * elastic/master: [ML] relax set upgrade mode test to match what is guaranteed (elastic#41958) Add note about ILM action ordering (elastic#41771) Remove Version 6 pre-release constants (elastic#41517) Mute illegal interval rollup tests Add static section whitelist info to api docs generation (elastic#41870) Cleanup RollupSearch exceptions, disallow partial results (elastic#41272)
benwtrent
added a commit
that referenced
this pull request
May 9, 2019
benwtrent
added a commit
that referenced
this pull request
May 9, 2019
benwtrent
added a commit
that referenced
this pull request
May 9, 2019
benwtrent
added a commit
that referenced
this pull request
May 9, 2019
benwtrent
added a commit
that referenced
this pull request
May 9, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…#41958) * [ML] relax set upgrade mode test to match what is guaranteed * removing unused import
Contributor
|
@benwtrent I'm assuming there is nothing left to backport and removed the "backport pending" label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transport only waits for the assignment explanation to NOT be
AWAITING_UPGRADEand then it is returned. Since we are testing that MORE is done than that, that can cause a race condition in the test and make it flaky.This code is all the way back in 6.7, will need to back port there when possible.