[DOCS] Rewrite prefix query docs#41955
[DOCS] Rewrite prefix query docs#41955jrodewig merged 11 commits intoelastic:masterfrom jrodewig:prefix-query-rewrite
prefix query docs#41955Conversation
|
Pinging @elastic/es-search |
|
@elasticmachine run elasticsearch-ci/docs-check |
|
@elasticmachine run elasticsearch-ci/docbldesx |
cbuescher
left a comment
There was a problem hiding this comment.
Nice rewrite again, I left two small questions.
|
|
||
| A boost can also be associated with the query: | ||
| [[prefix-query-top-level-params]] | ||
| ==== Top-level parameters for `term` |
There was a problem hiding this comment.
Should this be "prefix" instead of "term"?
There was a problem hiding this comment.
Good catch. Copy/paste error. Fixed with 1e6ca49.
| "prefix": { | ||
| "user": { | ||
| "value": "ki", | ||
| "rewrite": "constant_score" |
There was a problem hiding this comment.
I'm wondering if this parameter should be included in the "default" example since IMHO its pretty much an advanced parameter and mentioned later (also, constant_score should be the default, so not necessary here).
Did you consider also documenting the previous "short" form or do we want to discourage ppl. from using it?
There was a problem hiding this comment.
Great question!
I've been using the longer form requests because it's easier to delineate additional parameters. This is less of an issue with the prefix query, but I used the longer form so it's consistent with other queries. However, I'm open to changing this if wanted.
I've removed the rewrite parameter and added a "short request example" with 1e6ca49 and d58de59.
|
Thanks again for your review, @cbuescher. I've made a few changes in response to your feedback. Let me know if you have any other thoughts. |
|
It might be worth also referring to the |
|
Great suggestion @romseygeek. I've added a section for |
cbuescher
left a comment
There was a problem hiding this comment.
Thanks for the changes, LGTM
Changes
prefixqueryboostandrewriteparameters in example requestThis is part of #40977, an effort to standardize documentation for query types.
Any and all feedback welcome!
Before
Before image
After
After image