Skip to content

[DOCS] Escape deprecated[] macro for Asciidoctor migration#41608

Merged
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:asciidoctor-certgen
Apr 30, 2019
Merged

[DOCS] Escape deprecated[] macro for Asciidoctor migration#41608
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:asciidoctor-certgen

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Apr 26, 2019

Asciidoctor does not render text following the second comma in deprecated[] macros. This escapes the text in the deprecated[] macro in preparation for the Asciidoctor migration.

Quotes will be included in the existing AsciiDoc output, but I don't think that's too disruptive. It'll also be removed after the Asciidoctor migration is complete.

Relates to elastic/docs#827

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig changed the title [DOCS] Escape depcreated[] macro for Asciidoctor migration [DOCS] Escape deprecated[] macro for Asciidoctor migration Apr 29, 2019
Copy link
Copy Markdown
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit ddafdb8 into elastic:master Apr 30, 2019
@jrodewig jrodewig deleted the asciidoctor-certgen branch April 30, 2019 19:19
akhil10x5 pushed a commit to akhil10x5/elasticsearch that referenced this pull request May 2, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants