[DOCS] Fix delimited blocks for Asciidoctor migration#41583
Merged
jrodewig merged 2 commits intoelastic:masterfrom Apr 26, 2019
jrodewig:asciidoctor-restart-upgrade
Merged
[DOCS] Fix delimited blocks for Asciidoctor migration#41583jrodewig merged 2 commits intoelastic:masterfrom jrodewig:asciidoctor-restart-upgrade
jrodewig merged 2 commits intoelastic:masterfrom
jrodewig:asciidoctor-restart-upgrade
Conversation
Collaborator
|
Pinging @elastic/es-docs |
nik9000
reviewed
Apr 26, 2019
Member
nik9000
left a comment
There was a problem hiding this comment.
CI blew up on it! Did you happen to commit half of the fix? Like just the opening of the delimited block but not the closing?
Contributor
Author
|
Yep. That's exactly what happened. Fixed with 7ebb143. |
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 26, 2019
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Asciidoctor, these delimited block resets the nested ordered list (changing
dtoaand6to1). This fixes those breaking changes.Asciidoctor output before changes
Asciidoctor output after changes
AsciiDoc output after changes