Docs: Specify two IDs in migration docs#41501
Merged
nik9000 merged 1 commit intoelastic:7.xfrom Apr 24, 2019
Merged
Conversation
We link to these migraiton docs but we don't specify the id. This isn't great practice in general and is preventing us from migrating to Asciidoctor because it generates ids in a slightly different way.
jrodewig
approved these changes
Apr 24, 2019
Contributor
jrodewig
left a comment
There was a problem hiding this comment.
LGTM and builds successfully
nik9000
added a commit
that referenced
this pull request
Apr 24, 2019
We link to these migraiton docs but we don't specify the id. This isn't great practice in general and is preventing us from migrating to Asciidoctor because it generates ids in a slightly different way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We link to these migraiton docs but we don't specify the id. This
isn't great practice in general and is preventing us from migrating to
Asciidoctor because it generates ids in a slightly different way.