[DOCS] Remove inline callouts in SQL Command docs for Asciidoctor migration#41276
Merged
jrodewig merged 2 commits intoelastic:masterfrom Apr 22, 2019
jrodewig:fix-asciidoctor-errors-sql-commands
Merged
[DOCS] Remove inline callouts in SQL Command docs for Asciidoctor migration#41276jrodewig merged 2 commits intoelastic:masterfrom jrodewig:fix-asciidoctor-errors-sql-commands
jrodewig merged 2 commits intoelastic:masterfrom
jrodewig:fix-asciidoctor-errors-sql-commands
Conversation
Collaborator
|
Pinging @elastic/es-docs |
Collaborator
|
Pinging @elastic/es-search |
nik9000
approved these changes
Apr 17, 2019
| DESCRIBE [table identifier<1> | [LIKE pattern<2>]] | ||
| DESCRIBE | ||
| [table identifier | <1> | ||
| [LIKE pattern]] <2> |
Member
There was a problem hiding this comment.
I'd probably vertically align these but it isn't a big deal either way.
Contributor
Author
Member
|
Thanks! Still LGTM. |
Member
|
LGTM |
jrodewig
added a commit
that referenced
this pull request
Apr 22, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 22, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 22, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes inline callouts from the SQL Commands documentation. This change helps prepare Elasticsearch docs for Asciidoctor migration.
Per https://asciidoctor.org/docs/user-manual/#callouts, AsciiDoctor enforces this requirement: "The callout number (at the target) must be placed at the end of the line."
Relates to #41128
Before / After Rendering
DESCRIBE TABLE
Before
After
SHOW COLUMNS
Before
After
SHOW FUNCTIONS
Before
After
SHOW TABLES
Before
After
