[DOCS] Replace nested open block for Asciidoctor migration#41168
[DOCS] Replace nested open block for Asciidoctor migration#41168jrodewig merged 2 commits intoelastic:masterfrom jrodewig:fix-asciidoctor-errors-index-modules
Conversation
|
Pinging @elastic/es-docs |
|
If the table renders well I'm happy with it. I know we usually use definition lists because tables tend to come out poorly when we try to use them for this sort of thing. |
|
Thanks for the feedback @nik9000. Here's a screenshot from my local build:
I agree that tables generally aren't preferred, but I couldn't figure out a way to nest a definition list and still stay Asciidoctor valid. Please feel free to leave a suggestion or point me the right way if I'm overlooking something though. |
|
Another possible solution that seems to work for me is this:
|
|
Thanks for the solve @lcawl. Pushed c5b9aa2 to reformat the table to a definition list. I feel much better about this without a table. Updated screenshot: |
lcawl
left a comment
There was a problem hiding this comment.
LGTM and builds successfully
* [DOCS] Fix nested open blocks for Asciidoctor migration * [DOCS] Reformat table to definitions
* [DOCS] Fix nested open blocks for Asciidoctor migration * [DOCS] Reformat table to definitions
…1168) * [DOCS] Fix nested open blocks for Asciidoctor migration * [DOCS] Reformat table to definitions
Per asciidoctor/asciidoctor#1121, Asciidoctor does not currently allow nested open blocks. This removes the nested open block from the Index modules page and replaces it with a table.
This prevents the following error:
INFO:build_docs:asciidoctor: ERROR: illegal block content outside of partintro blockRelates to #41128