Skip to content

[DOCS] Fix callout for Asciidoctor migration#41129

Merged
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:fix-asciidoctor-errors
Apr 11, 2019
Merged

[DOCS] Fix callout for Asciidoctor migration#41129
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:fix-asciidoctor-errors

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Apr 11, 2019

Per https://asciidoctor.org/docs/user-manual/#callouts, AsciiDoctor enforces this requirement: "The callout number (at the target) must be placed at the end of the line."

This prevents the following error:
INFO:build_docs:asciidoctor: WARNING: query-dsl/script-score-query.asciidoc: line 109: no callout found for <1>

Relates to #41128

@jrodewig jrodewig requested review from lcawl and nik9000 April 11, 2019 19:25
@jrodewig jrodewig added :Docs >docs General docs changes labels Apr 11, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs

Copy link
Copy Markdown
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 391ac5a into elastic:master Apr 11, 2019
@jrodewig jrodewig deleted the fix-asciidoctor-errors branch April 11, 2019 19:51
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants