Move primary term from replicas proxy to repl op#41119
Merged
DaveCTurner merged 1 commit intoelastic:masterfrom Apr 11, 2019
Merged
Conversation
A small refactoring that removes the primaryTerm field from ReplicasProxy and instead passes it directly in to the methods that need it.
Collaborator
|
Pinging @elastic/es-distributed |
dnhatn
approved these changes
Apr 11, 2019
Member
dnhatn
left a comment
There was a problem hiding this comment.
LGTM.
Just curious about the benefits of this refactoring?
Member
Author
DaveCTurner
added a commit
that referenced
this pull request
Apr 11, 2019
A small refactoring that removes the primaryTerm field from ReplicasProxy and instead passes it directly in to the methods that need it. Relates #40706.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
A small refactoring that removes the primaryTerm field from ReplicasProxy and instead passes it directly in to the methods that need it. Relates elastic#40706.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small refactoring that removes the primaryTerm field from ReplicasProxy and
instead passes it directly in to the methods that need it.