[ML] checking if p-tasks metadata is null before updating state#41091
Merged
benwtrent merged 3 commits intoelastic:6.7from Apr 11, 2019
Merged
[ML] checking if p-tasks metadata is null before updating state#41091benwtrent merged 3 commits intoelastic:6.7from
benwtrent merged 3 commits intoelastic:6.7from
Conversation
Collaborator
|
Pinging @elastic/ml-core |
Contributor
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
Looks good. I am not sure if this is testable, but if it is it would be nice to add a unit test that fails without the fix.
benwtrent
commented
Apr 11, 2019
x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/integration/MlConfigMigratorIT.java
Outdated
Show resolved
Hide resolved
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 11, 2019
…tic#41091) * [ML] checking if p-tasks metadata is null before updating state * Adding test that validates fix * removing debug println
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 11, 2019
…tic#41091) * [ML] checking if p-tasks metadata is null before updating state * Adding test that validates fix * removing debug println
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 11, 2019
…tic#41091) * [ML] checking if p-tasks metadata is null before updating state * Adding test that validates fix * removing debug println
benwtrent
added a commit
that referenced
this pull request
Apr 11, 2019
…) (#41123) * [ML] checking if p-tasks metadata is null before updating state * Adding test that validates fix * removing debug println
benwtrent
added a commit
that referenced
this pull request
Apr 11, 2019
…) (#41122) * [ML] checking if p-tasks metadata is null before updating state * Adding test that validates fix * removing debug println
benwtrent
added a commit
that referenced
this pull request
Apr 11, 2019
…) (#41124) * [ML] checking if p-tasks metadata is null before updating state * Adding test that validates fix * removing debug println
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…tic#41091) (elastic#41124) * [ML] checking if p-tasks metadata is null before updating state * Adding test that validates fix * removing debug println
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
PersistentTasksCustomMetaData.TYPEis null, we would put anullvalue in the cluster state, which will fail thesubmitStateUpdateTask.This does a
nullcheck to verify it is non-null before adding it to the metadata. All of the other methods in the class that interact with aPersistentTasksCustomMetaDataalready do a null checkcloses #41090