[DOCS] Improve docs for 'elasticsearch-keystore add-file' command#41084
Merged
jrodewig merged 2 commits intoelastic:masterfrom Apr 11, 2019
jrodewig:doc-keystore-add-file
Merged
[DOCS] Improve docs for 'elasticsearch-keystore add-file' command#41084jrodewig merged 2 commits intoelastic:masterfrom jrodewig:doc-keystore-add-file
jrodewig merged 2 commits intoelastic:masterfrom
jrodewig:doc-keystore-add-file
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
Collaborator
|
Pinging @elastic/es-core-infra |
Collaborator
|
Pinging @elastic/es-security |
rjernst
approved these changes
Apr 10, 2019
Member
rjernst
left a comment
There was a problem hiding this comment.
This looks good. As a separate concern, I think we need to somehow explain that add and add-file are dependent on the specific setting being set. We have had many users confused, thinking that they can use the keystore for any setting they wish. But each setting is very specific about the type of data that must be stored, including whether it is in the keystore.
Contributor
Author
jrodewig
added a commit
that referenced
this pull request
Apr 11, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 11, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 11, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 11, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 11, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 11, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 11, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elasticsearch-keystore add-filecommand on the Secure settings pageelasticsearch-keystore add-fileexample on GCS Plugin's Client Settings page.Resolves #35433