Index Stats: Add support for segments stats#4102
Closed
kimchy wants to merge 1 commit intoelastic:masterfrom
Closed
Index Stats: Add support for segments stats#4102kimchy wants to merge 1 commit intoelastic:masterfrom
kimchy wants to merge 1 commit intoelastic:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Having a handler per stats type was already the setup, but I think we can have a base class to all of them and save on this boiler plate code which all of them have.
Member
Author
There was a problem hiding this comment.
agreed, we should refactor it!, we need to do it in another change though...
Contributor
|
Good addition. Left some minor comments. |
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 11, 2026
Add test for multi-project snapshot support elastic#130000
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 11, 2026
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 11, 2026
Add test for multi-project snapshot support elastic#130000
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4101