Restricts naming for repositories#41008
Conversation
c385b3c to
8091418
Compare
|
Pinging @elastic/es-distributed |
71392e2 to
d1861ab
Compare
original-brownbear
left a comment
There was a problem hiding this comment.
@danhermann thanks! I think this is fine, can you add a quick test that checks these conditions as well please?
|
@ywelsch maybe you can take a quick look too, to confirm that it's fine to restrict naming like this (looks like the same conditions as for snapshot naming are in here as well which makes perfect sense to me)? |
ywelsch
left a comment
There was a problem hiding this comment.
I've left some comments. Thank you for contributing this PR.
There was a problem hiding this comment.
this is already covered by filename check
There was a problem hiding this comment.
this is already covered by filename check
There was a problem hiding this comment.
this is a method that is internally called both on repository creation, but also after a restart when a node rejoins a cluster with an existing repository. I think we should do the validation only for new repository creation requests, and not retroactively apply to old repositories (which will break them). This means that the validation should be done in registerRepository, not createRepository.
…except that leading underscores and uppercase characters are permitted. Fixes elastic#40817.
d1861ab to
55022a3
Compare
Applies the same naming restrictions to repositories as to snapshots except that leading underscores and uppercase characters are permitted. Fixes elastic#40817.
Applies the same naming restrictions to repositories as to snapshots except that leading underscores and uppercase characters are permitted. Fixes elastic#40817.
Applies the same naming restrictions to repositories as to snapshots except that leading underscores and uppercase characters are permitted.
Fixes #40817.