[ML] addressing test failure#40701
Merged
benwtrent merged 4 commits intoelastic:masterfrom Apr 2, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core |
70bc21f to
9a61c46
Compare
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 2, 2019
* [ML] Fixing test * adjusting line lengths * marking valid seqno as final
benwtrent
added a commit
that referenced
this pull request
Apr 2, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* [ML] Fixing test * adjusting line lengths * marking valid seqno as final
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the seqNoStats variable was being overridden by the "invalid" seqNoStats variable. Consequently, if the first replica was "invalid" all the following would be two, so they would be consistently "invalid" and thus seen as "valid".
Changing the code so that the valid stats are not overridden by the invalid ones.
closes #40368