Remove -Xlint exclusions in the ingest-common module.#40505
Merged
martijnvg merged 2 commits intoelastic:masterfrom Mar 29, 2019
Merged
Remove -Xlint exclusions in the ingest-common module.#40505martijnvg merged 2 commits intoelastic:masterfrom
martijnvg merged 2 commits intoelastic:masterfrom
Conversation
The generics in AbstractStringProcessor is not needed (IngestDocument#setFieldValue(...) accepts Object) and therefor it was removed. Otherwise the corresponding factory implementations would need typing too. Relates to elastic#40366
Collaborator
|
Pinging @elastic/es-core-infra |
23 tasks
alpar-t
reviewed
Mar 27, 2019
| * | ||
| * @param <T> The resultant type for the target field | ||
| */ | ||
| abstract class AbstractStringProcessor<T> extends AbstractProcessor { |
Contributor
There was a problem hiding this comment.
There's more classes to change, but I'm wondering if ti's worth changing the classes that extend from this to include a type instead like so:
public final class BytesProcessor extends AbstractStringProcessor<Long> {
This would allow us to keep type safety for the process issue
Member
Author
There was a problem hiding this comment.
I can go either way. The type wasn't really used, so I thought I should remove it, but what you;re suggestion is good too, as it remove those -Xlint exclusions too. @jakelandis what do you think?
Contributor
There was a problem hiding this comment.
I would prefer to leave the generic type there. I think I added it, but didn't bother with explicitly satisfying the generic since is implicitly satisfied by the abstract T process method.
It looks like the lint exclusions pre-dated this change, and not sure if explicitly satisfying the generic will allow for a clean removal of the exclusion. (I am bit surprised that implicitly satisfying generics trigger lint warnings)
martijnvg
added a commit
that referenced
this pull request
Mar 29, 2019
Fix the generics in processors extending AbstractStringProcessor and its factory. Relates to #40366
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 29, 2019
* elastic/master: (77 commits) Update ingest jdocs that a null return value will drop the current document. (elastic#40359) Remove -Xlint exclusions in the ingest-common module. (elastic#40505) Update docs for the DFR similarity (elastic#40579) Fix merging of search_as_you_type field mapper (elastic#40593) Support roles with application privileges against wildcard applications (elastic#40398) Remove obsolete security settings (elastic#40496) Remove Gradle deprecation warnings (elastic#40449) Run the build integ test in parallel (elastic#39788) Fix 3rd pary S3 tests (elastic#40588) lower bwc skip for search as you type (elastic#40599) Muting XContentParserTests#testSubParserArray Fixing typo in test error message (elastic#40611) Update max dims for vectors to 1024. (elastic#40597) Add start and stop time to cat recovery API (elastic#40378) [DOCS] Correct keystore commands for Email and Jira actions in Watcher (elastic#40417) [DOCS] Document common settings for snapshot repository plugins (elastic#40475) Remove with(out)-system-key tests (elastic#40547) Geo Point parse error fix (elastic#40447) Handle null retention leases in WaitForNoFollowersStep (elastic#40477) [DOCS] Adds anchors for ruby client (elastic#39867) ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 29, 2019
* elastic/master: (129 commits) Update ingest jdocs that a null return value will drop the current document. (elastic#40359) Remove -Xlint exclusions in the ingest-common module. (elastic#40505) Update docs for the DFR similarity (elastic#40579) Fix merging of search_as_you_type field mapper (elastic#40593) Support roles with application privileges against wildcard applications (elastic#40398) Remove obsolete security settings (elastic#40496) Remove Gradle deprecation warnings (elastic#40449) Run the build integ test in parallel (elastic#39788) Fix 3rd pary S3 tests (elastic#40588) lower bwc skip for search as you type (elastic#40599) Muting XContentParserTests#testSubParserArray Fixing typo in test error message (elastic#40611) Update max dims for vectors to 1024. (elastic#40597) Add start and stop time to cat recovery API (elastic#40378) [DOCS] Correct keystore commands for Email and Jira actions in Watcher (elastic#40417) [DOCS] Document common settings for snapshot repository plugins (elastic#40475) Remove with(out)-system-key tests (elastic#40547) Geo Point parse error fix (elastic#40447) Handle null retention leases in WaitForNoFollowersStep (elastic#40477) [DOCS] Adds anchors for ruby client (elastic#39867) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generics in AbstractStringProcessor is not needed
(IngestDocument#setFieldValue(...) invocation in
AbstractStringProcessor accepts Object) and therefor it
was removed. Otherwise the corresponding factory
implementations would need typing too.
Relates to #40366